From: Sundeep Mediratta <smedius@gmail.com>
Date: Sun, 4 Aug 2024 17:33:47 +0000 (-0400)
Subject: ibusManager: Change return value of `setCompletionEnabled()`
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~204^2^2~20
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=2975afaf1de2820c11129637d8af4511ef7fc40a;p=gnome-shell.git

ibusManager: Change return value of `setCompletionEnabled()`

The return value currently indicates whether the request was
successful, namely `setCompletionEnabled(false)` will return
`true` if completions were successfully disabled.

However the only caller that uses the value uses it to indicate
whether completions were enabled.

Given that nothing else uses the value, change the meaning to
match the caller, and indicate whether completions are enabled
after the call returns.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3439>
---

diff --git a/js/misc/ibusManager.js b/js/misc/ibusManager.js
index a4931cfb9..8d4973564 100644
--- a/js/misc/ibusManager.js
+++ b/js/misc/ibusManager.js
@@ -333,6 +333,11 @@ class IBusManager extends Signals.EventEmitter {
                 });
     }
 
+    /**
+     * @param {boolean} enabled - whether completion should be enabled
+     *
+     * @returns {boolean} - whether completion are enabled
+     */
     async setCompletionEnabled(enabled) {
         /* Needs typing-booster available */
         if (enabled && !this._engines.has(TYPING_BOOSTER_ENGINE))
@@ -342,7 +347,7 @@ class IBusManager extends Signals.EventEmitter {
             return false;
 
         if (this._oskCompletion === enabled)
-            return true;
+            return enabled;
 
         this._oskCompletion = enabled;
 
@@ -353,6 +358,6 @@ class IBusManager extends Signals.EventEmitter {
             await this._setEngine(this._preOskEngine);
             delete this._preOskEngine;
         }
-        return true;
+        return this._oskCompletion;
     }
 }